Skip to main content

PHP screwed me again...

Writing a WordPress plugin this time, as Fletcher might have said,
"You wanna stay away from nonces Gobber, bad news they are."
My code had created a meta-box to allow me to tick / untick a simple check-box against pages and posts so that I could restrict content to registered users. Every time I hit the "update" button I got the lovely little error box telling me there was a problem saving my post and to try again. Thanks WP, very helpful.

Anyway, I tracked the problem to a piece of code that I had transcribed incorrectly from the WP codex page, don't ask me why I hadn't cut and pasted it directly from the page as I normally do, but here's what I had and what I should have had, first the bad code...

wp_nonce_field(
  plugin_basename(
    __FILE__, 'tnjpay_restricted_nonce'
  ),
);

and the correct code is...

wp_nonce_field(
  plugin_basename(__FILE__),
  'tnjpay_restricted_nonce'
);

Simple, but in the cut-and-thrust I just couldn't see that one little mistake; that I had accidentally put the nonce identifier inside the call to plugin_basename instead of as the second parameter to wp_nonce_field. And PHP never said a mumbling word. Thanks PHP.

Admittedly wp_nonce_field takes four parameters and they are all optional so that function I will forgive, but plugin_basename takes one and exactly one parameter but because of the incredibly slack (and useful) way in which PHP lets you pass arguments around, it never complained. Is there some kind of configuration  file setting that would have moaned at me for having given it too much to eat? That would have at least saved some head-scratching! 

If I was being very strict then I would insist that all functions that are not variadic should do this as the first line of code inside the stack frame:

assert(count(func_get_args(), N));

It's a shame that PHP doesn't have a pre-processor. I have used m4 with PHP in the past but on production sites not everybody knows how to use m4 or why it's even useful! Whatever.

I will not make that particular mistake again, at least not today with the WP API.


Labels:

Comments

Post a Comment

Popular posts from this blog

Communicating between controllers in AngularJS

I have seen many solutions to how to make controllers talk to each other whilst at the same time remaining within "da rulez" of writing Angular applications. I have been using Angular for about a month now and at times it has been swearier than a good Haskell session, it is most definitely worth it all in the end. I have written a really nice looking web application for my employer and they seem to like it. I think Angular. One thing I really aced (to my own satisfaction at least) was wrapping a REST (of any type) API using a resource. I will make a separate post about that. Do the simplest thing... Here is my own solution to the problem of how you can make different controllers communicate cleanly using the "event" system that Angular provides. All you have to do is ensure that the following event listener is added to your application root-scope: App.run( function( $rootScope )) { $rootScope.$on('broadcast', function( e, data ) { if (undef...
3 comments
Read more

Cross platform development with Scheme

Just a quick note about something I recently found whilst trying not to buy MOCL… http://www.lambdanative.org/ LambdaNative is developed and maintained by the Pediatric Anethesia Research Team (PART) and the Electical and Computer Engineering in Medicine (ECEM) group at the University of British Columbia (UBC). I have spent a week or two evaluating it and accidentally contributed a pull request that got merged and one that didn’t and I have to say that, for what it offers, it is awesomely good. Having personally spent many hours with it now, I do not yet think it is ready for mainstream development for a few reasons. I don’t mean that it a bad way either. What I mean is that the language, Scheme, is not really that widely known and as such it probably won’t break out into the public arena any time yet. That’s a real shame because I think that they have achieved an amazing thing; total abstraction of the underlying platform with a really powerful, underestimated language. ...
1 comment
Read more

Handling multipart/form-data with NanoHTTPD

I am in the process of reviving an old project from 2014 that I never finished because of other work commitments. In that time, bitrot has set in, the Android API has moved on and all in all, the home-brewed HTTP server I wrote using SocketServer and the org.apache libraries had to go! I looked around, found a couple of contenders and after much time decided to go with NanoHTTPD because it is lean, small and fits in exactly two files. The main server is in one file `NanoHTTPD.java`and there is another file called `ServerRunner.java` which manages instances of running servers. The others The other project I looked at is this one:  https://github.com/koush/AndroidAsync which led me a merry dance and I just couldn't figure out how get the POST data I had uploaded. I spent a few days really digging at it with Wire Shark too to make sure the data was going up. It was. Whatever... I had used it via a gradle dependency entry but I dropped it and went back to NanoHTTPD. For m...
Post a Comment
Read more