Skip to main content

PHP screwed me again...

Writing a WordPress plugin this time, as Fletcher might have said,
"You wanna stay away from nonces Gobber, bad news they are."
My code had created a meta-box to allow me to tick / untick a simple check-box against pages and posts so that I could restrict content to registered users. Every time I hit the "update" button I got the lovely little error box telling me there was a problem saving my post and to try again. Thanks WP, very helpful.

Anyway, I tracked the problem to a piece of code that I had transcribed incorrectly from the WP codex page, don't ask me why I hadn't cut and pasted it directly from the page as I normally do, but here's what I had and what I should have had, first the bad code...

wp_nonce_field(
  plugin_basename(
    __FILE__, 'tnjpay_restricted_nonce'
  ),
);

and the correct code is...

wp_nonce_field(
  plugin_basename(__FILE__),
  'tnjpay_restricted_nonce'
);

Simple, but in the cut-and-thrust I just couldn't see that one little mistake; that I had accidentally put the nonce identifier inside the call to plugin_basename instead of as the second parameter to wp_nonce_field. And PHP never said a mumbling word. Thanks PHP.

Admittedly wp_nonce_field takes four parameters and they are all optional so that function I will forgive, but plugin_basename takes one and exactly one parameter but because of the incredibly slack (and useful) way in which PHP lets you pass arguments around, it never complained. Is there some kind of configuration  file setting that would have moaned at me for having given it too much to eat? That would have at least saved some head-scratching! 

If I was being very strict then I would insist that all functions that are not variadic should do this as the first line of code inside the stack frame:

assert(count(func_get_args(), N));

It's a shame that PHP doesn't have a pre-processor. I have used m4 with PHP in the past but on production sites not everybody knows how to use m4 or why it's even useful! Whatever.

I will not make that particular mistake again, at least not today with the WP API.


Labels:

Comments

Post a Comment

Popular posts from this blog

PHP and Lisp: multiple-value-bind (MVB)

This is another article in my attempts to find new ways of looking at PHP and making it less of a chore to type in all that code. As much as I love PHP I hate wasting keystrokes. More typing is more errors is more grief. Being an off and on user of Lisp, although not as much as I used to, one of the things that I always liked in Lisp was the ability to be able to return multiple values from a function at once using (values) and then marry that with (multiple-value-bind) to create convenient named bindings for whatever you were about to do. I recently found myself wanting to return a couple of values from a helper function and I just didn't want to go to the trouble of having to type all those character required to create an array with keys for the two values and then I remembered MVB and a little light went on in my head! If somebody else has already done this then I apologise up front but it was new to me and I haven't seen it anywhere else so this could be a first! ...
Post a Comment
Read more

Angular.JS ... absolutely awesome BUT...

Aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaagh! Sort the documentation soon please!  More soon, I really do like it though. :)
Post a Comment
Read more

You are not here not reading this post...

Some days it's hard to really appreciate what a software developer is or does. And I have "been one" for over a quarter of a century and I still don't know what I do. I can translate management speak into meaningful English and then understand what "they need" as opposed to "what they think they need." I can translate "business requirements" into an internal mental model composed of data stores and processes and subsequently translate that model into "working code" in any language you care to mention to produce a "deliverable". But... I still don't truly understand what happened along the way. I think it is more to do with the underlying nature of the universe rather than the mechanical processes. Codds rules and normalisation for instance, one can learn, understand and apply these rules to great effect but what does "de-normalisation to 2NF" mean to a bunch of atoms and molecules which don't...
Post a Comment
Read more