Skip to main content

PHP screwed me again...

Writing a WordPress plugin this time, as Fletcher might have said,
"You wanna stay away from nonces Gobber, bad news they are."
My code had created a meta-box to allow me to tick / untick a simple check-box against pages and posts so that I could restrict content to registered users. Every time I hit the "update" button I got the lovely little error box telling me there was a problem saving my post and to try again. Thanks WP, very helpful.

Anyway, I tracked the problem to a piece of code that I had transcribed incorrectly from the WP codex page, don't ask me why I hadn't cut and pasted it directly from the page as I normally do, but here's what I had and what I should have had, first the bad code...

wp_nonce_field(
  plugin_basename(
    __FILE__, 'tnjpay_restricted_nonce'
  ),
);

and the correct code is...

wp_nonce_field(
  plugin_basename(__FILE__),
  'tnjpay_restricted_nonce'
);

Simple, but in the cut-and-thrust I just couldn't see that one little mistake; that I had accidentally put the nonce identifier inside the call to plugin_basename instead of as the second parameter to wp_nonce_field. And PHP never said a mumbling word. Thanks PHP.

Admittedly wp_nonce_field takes four parameters and they are all optional so that function I will forgive, but plugin_basename takes one and exactly one parameter but because of the incredibly slack (and useful) way in which PHP lets you pass arguments around, it never complained. Is there some kind of configuration  file setting that would have moaned at me for having given it too much to eat? That would have at least saved some head-scratching! 

If I was being very strict then I would insist that all functions that are not variadic should do this as the first line of code inside the stack frame:

assert(count(func_get_args(), N));

It's a shame that PHP doesn't have a pre-processor. I have used m4 with PHP in the past but on production sites not everybody knows how to use m4 or why it's even useful! Whatever.

I will not make that particular mistake again, at least not today with the WP API.


Labels

Labels:

Comments

Post a Comment

Popular posts from this blog

The Coolest Shortest PHP Function I Will Ever Write

Having now released my own programming language, FELT , and learned a lot about this and that in the process I have of late, in the evenings, been struggling to reconcile my love of LISP and how simple FELT makes some PHP coding task leaner and meaner with the fact that I still have to use PHP for my day job. In my language, FELT , I have used the square brackets to define a "normal" array and curly braces to define a "key-value" array, mainly because this is identical to JSON format and anybody familiar with Javascript coding just won't have any issues getting to grips with that now will they! Let's take some simple examples of FELT code: (defvar simple-array [1 2 3 4]) (defvar simple-map {:name "Eric" :age 42 :occupation "Viking Hacker"}) When FELT has done its thing, we get the following PHP code, $simple_array = array(1, 2, 3, 4); $simple_map = array('name' => "Eric", 'age' => 42, ...
Post a Comment
Read more

Prime Peace

I think prime numbers are the numerical expression of peace. Restful nodes in the vibration of everything. Prime factorisation has always struck me as something truly astounding and it is reassuring to know that awsesome minds are hard at work trying to solve the Riemann hypothesis right now. There are some truly wonderful professional and amateur (in the nicest sense of the word) explorations I have watched recently and the ones that moved me the most, in order of cool factor were: This guy,Carlos Paris, has put in some serious work with AutoCAD and made some interesting observations. I truly enjoyed watching all of his four videos. Awesome work Carlos. As an interested amateur I found his work and thoughts to be very compelling. I am sure the professionals would groan or moan but to me this video is most excellent and informative. Speaking of the professionals, this video is also very interesting to watch as it goes some way to visually explaining the Riemann hypothesis in...
Post a Comment
Read more

Handling multipart/form-data with NanoHTTPD

I am in the process of reviving an old project from 2014 that I never finished because of other work commitments. In that time, bitrot has set in, the Android API has moved on and all in all, the home-brewed HTTP server I wrote using SocketServer and the org.apache libraries had to go! I looked around, found a couple of contenders and after much time decided to go with NanoHTTPD because it is lean, small and fits in exactly two files. The main server is in one file `NanoHTTPD.java`and there is another file called `ServerRunner.java` which manages instances of running servers. The others The other project I looked at is this one:  https://github.com/koush/AndroidAsync which led me a merry dance and I just couldn't figure out how get the POST data I had uploaded. I spent a few days really digging at it with Wire Shark too to make sure the data was going up. It was. Whatever... I had used it via a gradle dependency entry but I dropped it and went back to NanoHTTPD. For m...
Post a Comment
Read more